[PATCH] D57973: [MemorySSA] Remove verifyClobberSanity.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 10:47:50 PST 2019


george.burgess.iv added a comment.

Thanks! Just a tiny nit



================
Comment at: lib/Analysis/MemorySSA.cpp:1798
 
 void MemorySSA::verifyClobberSanity(const Function &F) const {
+// The original intention of this method is verify that the clobberingAccess
----------------
If this is entirely unused now, can we stash the comments about how this isn't guaranteed in `verifyMemorySSA` and delete this method entirely? I'd rather not carry dead code. :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57973/new/

https://reviews.llvm.org/D57973





More information about the llvm-commits mailing list