[PATCH] D57789: [CGP] form usub with overflow from sub+icmp

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 10:29:52 PST 2019


spatel updated this revision to Diff 186286.
spatel added a comment.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Patch updated:
Side-step controversy by adding a TLI hook. This should preserve existing behavior for uaddo and usubo for all targets, except x86 which now allows usubo formation. It seems likely that other targets like AArch64, AMDGPU, and PPC should allow usubo too, but they can do that selectively as follow-ups.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57789/new/

https://reviews.llvm.org/D57789

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/CodeGenPrepare.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h
  llvm/test/CodeGen/X86/cgp-usubo.ll
  llvm/test/CodeGen/X86/lsr-loop-exit-cond.ll
  llvm/test/Transforms/CodeGenPrepare/X86/overflow-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57789.186286.patch
Type: text/x-patch
Size: 22331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190211/28eb1ed4/attachment.bin>


More information about the llvm-commits mailing list