[PATCH] D57737: [AMDGPU] Fix DPP sequence in atomic optimizer.

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 02:37:31 PST 2019


dstuttard accepted this revision.
dstuttard added a comment.
This revision is now accepted and ready to land.

Not really an area I'm 100% sure about - but looks ok to me. One of the other reviewers will have to sign off too.
Minor niggle on the comment (if my understanding is correct).



================
Comment at: lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:303
     // This loop performs an inclusive scan across the wavefront, with all lanes
     // active (by using the WWM intrinsic).
     for (unsigned Idx = 0; Idx < Iters; Idx++) {
----------------
Is this comment still true?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57737/new/

https://reviews.llvm.org/D57737





More information about the llvm-commits mailing list