[PATCH] D57854: [InstCombine] Optimize `atomicrmw <op>, 0` into `load atomic` when possible

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 22:07:58 PST 2019


reames added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:21
+    break;
+  case AtomicRMWInst::Add:
+  case AtomicRMWInst::Sub:
----------------
Any plans to handle the other obvious cases such as xor, and, etc?

On the inverse side, we can do the same thing converting to a blind store.  e.g. and w/zero, or max w/INT_MAX.  

Just curious as to what plans here are.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57854/new/

https://reviews.llvm.org/D57854





More information about the llvm-commits mailing list