[PATCH] D57952: llvm-lib: Implement /list flag

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp:99
 
+static void fatalOpenError(std::error_code EC, Twine File) {
+  if (!EC)
----------------
pcc wrote:
> Could you make this take an `llvm::Error` and change the caller with the `error_code` to use `errorCodeToError`? We're (slowly) trying to eradicate `std::error_code` and `errorToErrorCode` from the codebase.
Done, but not sure if the error printing code is how it's supposed to look; feels a bit roundabout.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57952/new/

https://reviews.llvm.org/D57952