[PATCH] D57875: [LegalizeTypes] Expand FNEG to bitwise op for IEEE FP types

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 15:11:01 PST 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

> Without this patch is the fneg instruction getting turned into a subtraction instruction? I hope not on any platform!

Without this patch we generate calls to __subsf3 etc.  There's also equivalent code in LegalizeDAG, but I think in practice it doesn't get used because targets with floating-point support generally have a native fneg instruction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57875/new/

https://reviews.llvm.org/D57875





More information about the llvm-commits mailing list