[PATCH] D57963: Fix Die() after pthread_exit call on macOS

[Yuri Per via Phabricator via llvm-commits]

yuri created this revision.
yuri added a reviewer: dvyukov.
yuri added a project: Sanitizers.
Herald added subscribers: Sanitizers, llvm-commits, jfb, kubamracek.
Herald added a project: LLVM.

Scoped interceptor should not be used when calling real pthread_exit().
On macOS C++ destructors are not called by pthread_exit(), and later check for empty thread ignore set fails.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D57963

Files:
  lib/tsan/rtl/tsan_interceptors.cc


Index: lib/tsan/rtl/tsan_interceptors.cc
===================================================================
--- lib/tsan/rtl/tsan_interceptors.cc
+++ lib/tsan/rtl/tsan_interceptors.cc
@@ -1051,7 +1051,9 @@
 }
 
 TSAN_INTERCEPTOR(void, pthread_exit, void *retval) {
-  SCOPED_TSAN_INTERCEPTOR(pthread_exit, retval);
+  {
+    SCOPED_INTERCEPTOR_RAW(pthread_exit, retval);
+  }
   REAL(pthread_exit)(retval);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57963.185999.patch
Type: text/x-patch
Size: 413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190208/e3af0d61/attachment.bin>