[PATCH] D57945: Small refactoring of FileError. NFC

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 10:11:30 PST 2019


rupprecht added inline comments.


================
Comment at: include/llvm/Support/Error.h:1221
+inline Error createFileError(const Twine &F, std::error_code EC) {
+  return createFileError(F, make_error<StringError>(EC));
+}
----------------
errorCodeToError(EC) seems more appropriate, given there is no string


================
Comment at: include/llvm/Support/Error.h:1224
+
 Error createFileError(std::string F, ErrorSuccess) = delete;
 
----------------
Update this too


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57945/new/

https://reviews.llvm.org/D57945





More information about the llvm-commits mailing list