[PATCH] D57942: [ARM] Add v8m.base pattern for add negative imm

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 04:19:52 PST 2019


fhahn added inline comments.


================
Comment at: test/CodeGen/ARM/sub.ll:10
 ; CHECK: f1
-; CHECK-LE: subs r0, r0, #171
+; CHECK-LE: subs{{.*}} r0, #171
 ; CHECK-LE: sbc r1, r1, #0
----------------
Why is this change and the similar ones needed?


================
Comment at: test/CodeGen/ARM/sub.ll:67
+entry:
+; CHECK: f6
+; CHECK: movw r1, #65535
----------------
Check-label


================
Comment at: test/CodeGen/ARM/sub.ll:73
+
+; CHECK-V6M: f6
+; CHECK-V6M: ldr
----------------
Check-label

Also it might be worth expanding the check for v6m a bit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57942/new/

https://reviews.llvm.org/D57942





More information about the llvm-commits mailing list