[PATCH] D57876: Implement pthread_exit() interceptor for Thread sanitizer

Yuri Per via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 02:41:04 PST 2019


yuri added a comment.

In D57876#1390150 <https://reviews.llvm.org/D57876#1390150>, @dvyukov wrote:

> One thing that I noticed is that pthread_exit is a noreturn function and SCOPED_TSAN_INTERCEPTOR creates a local object with destructor. At the very least this leads to confusing code where readers assumption is that the destructor will run, but it will not.
>  Perhaps we should try to remove the SCOPED_TSAN_INTERCEPTOR entirely as the CHECK that we want to add here does not need it.


Let's fix after resolution of test failures


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57876/new/

https://reviews.llvm.org/D57876





More information about the llvm-commits mailing list