[PATCH] D57929: [InstrProf] Implement static profdata registration

Thu Feb 7 16:47:34 PST 2019

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm.

================
Comment at: compiler-rt/lib/profile/InstrProfilingValue.c:34
     lprofValueProfNodes[INSTR_PROF_VNODE_POOL_SIZE] COMPILER_RT_SECTION(
-       COMPILER_RT_SEG INSTR_PROF_VNODES_SECT_NAME_STR);
+       COMPILER_RT_SEG INSTR_PROF_VNODES_SECT_NAME);
 #endif
----------------
rnk wrote:
> davidxl wrote:
> > What is this change for?
> When I compiled my original change on Linux, I encountered warnings about this code:
>   #define INSTR_PROF_DATA_COFF .lprfd$M
> Clang warns that dollars in identifiers are considered to be an extension. To address that, I quoted the COFF strings, and eliminated the *_STR macros.
> 
> The only use of the section names that needs to not be quoted is the use in InstrProfilingPlatformLinux.c, which I modified to use INSTR_PROF_INSTR_PROF_DATA_COMMON to build the __start / __stop section bounds symbols. This code is already platform specific, so it seemed OK to use the underlying *_COMMON macros.
> 
> If you like, I can separate that change out. Would you like me to upload it as a separate review?
ok.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57929/new/

https://reviews.llvm.org/D57929