[PATCH] D57350: [llvm-cxxfilt] Split and demangle stdin input

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

This essentially looks good to me, aside from the extra test suggestion. I'm away for a week after today, so I won't be able to respond to further review issues until I'm back. I'm happy for this to land once @compnerd is.



================
Comment at: llvm/test/tools/llvm-cxxfilt/simple.test:2-3
 RUN: llvm-cxxfilt _Z1fi abc | FileCheck %s
+RUN: echo "Mangled _Z1fi and _Z3foov in string." | llvm-cxxfilt \
+RUN:      | FileCheck %s --check-prefix=CHECK-STRING
 
----------------
It may be worth adding a test to show that reading this from the command-line doesn't cause it to be demangled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57350/new/

https://reviews.llvm.org/D57350