[PATCH] D57691: [yaml2obj][obj2yaml] - Add support for dumping/parsing .dynamic sections.

Fri Feb 8 01:54:47 PST 2019

jhenderson added a comment.

This change basically looks fine in itself. From what I remember of the discussion around D56569 <https://reviews.llvm.org/D56569>, there isn't anything here in the behaviour that conflicts with that change, I believe.

================
Comment at: lib/ObjectYAML/ELFYAML.cpp:677
+#define STRINGIFY(X) (#X)
+#define DYNAMIC_TAG(X, Y) IO.enumCase(Value, STRINGIFY(DT_##X), ELF::DT_##X);
+#include "llvm/BinaryFormat/DynamicTags.def"
----------------
I may be missing something, but why is this line different to the equivalent for e.g. the relocations above?

================
Comment at: test/tools/llvm-readobj/gnu-hash-symbols.test:77
+    Flags:           [ SHF_ALLOC ]
+    Address:         0x0000000000001000
+    Link:            .dynstr
----------------
Not that it really matters, but any particular reason you've moved this to before the Link field?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57691/new/

https://reviews.llvm.org/D57691