[PATCH] D56507: [PowerPC] Avoid scalarization of vector truncate

Thu Feb 7 15:42:03 PST 2019

RolandF marked an inline comment as done.
RolandF added inline comments.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

================
Comment at: llvm/test/CodeGen/PowerPC/vec-trunc.ll:18
+; CHECK-BE-LABEL: @test8i8
+; CHECK-BE: vpkuhum
+
----------------
jsji wrote:
> RolandF wrote:
> > jsji wrote:
> > > Maybe we should either add the check to `xxswapd` in BE ?
> > > Or else why not just remove all `CHECK-BE`? As they are all identical to `CHECK`?
> > LowerTRUNCATEVector has an if statement checking LE or BE, so even though we want the result to be the same in the end we have to test both LE and BE to test the whole function.
> Yes, we need to test both BE/LE, but no need to have CHECK-BE/CHECK-LE prefixes if the results are the same?
> 
> 
Oh, okay, I see what you mean now.  I could have saved a bunch of check lines.  

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56507/new/

https://reviews.llvm.org/D56507