[llvm] r353465 - Move SMTSolver dump() methods out-of-line.

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 13:03:18 PST 2019


Author: adrian
Date: Thu Feb  7 13:03:18 2019
New Revision: 353465

URL: http://llvm.org/viewvc/llvm-project?rev=353465&view=rev
Log:
Move SMTSolver dump() methods out-of-line.

This broke modularized non-local-submodule-visibility builds because
the function bodies pulled in extra dependencies.

Modified:
    llvm/trunk/include/llvm/Support/SMTAPI.h
    llvm/trunk/lib/Support/Z3Solver.cpp

Modified: llvm/trunk/include/llvm/Support/SMTAPI.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/SMTAPI.h?rev=353465&r1=353464&r2=353465&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/SMTAPI.h (original)
+++ llvm/trunk/include/llvm/Support/SMTAPI.h Thu Feb  7 13:03:18 2019
@@ -70,7 +70,7 @@ public:
 
   virtual void print(raw_ostream &OS) const = 0;
 
-  LLVM_DUMP_METHOD void dump() const { print(llvm::errs()); }
+  LLVM_DUMP_METHOD void dump() const;
 
 protected:
   /// Query the SMT solver and returns true if two sorts are equal (same kind
@@ -117,7 +117,7 @@ public:
 
   virtual void print(raw_ostream &OS) const = 0;
 
-  LLVM_DUMP_METHOD void dump() const { print(llvm::errs()); }
+  LLVM_DUMP_METHOD void dump() const;
 
 protected:
   /// Query the SMT solver and returns true if two sorts are equal (same kind
@@ -138,7 +138,7 @@ public:
   SMTSolver() = default;
   virtual ~SMTSolver() = default;
 
-  LLVM_DUMP_METHOD void dump() const { print(llvm::errs()); }
+  LLVM_DUMP_METHOD void dump() const;
 
   // Returns an appropriate floating-point sort for the given bitwidth.
   SMTSortRef getFloatSort(unsigned BitWidth) {

Modified: llvm/trunk/lib/Support/Z3Solver.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Z3Solver.cpp?rev=353465&r1=353464&r2=353465&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Z3Solver.cpp (original)
+++ llvm/trunk/lib/Support/Z3Solver.cpp Thu Feb  7 13:03:18 2019
@@ -824,3 +824,9 @@ llvm::SMTSolverRef llvm::CreateZ3Solver(
   return nullptr;
 #endif
 }
+
+LLVM_DUMP_METHOD void SMTSort::dump() const { print(llvm::errs()); }
+LLVM_DUMP_METHOD void SMTExpr::dump() const { print(llvm::errs()); }
+LLVM_DUMP_METHOD void SMTSolver::dump() const { print(llvm::errs()); }
+
+




More information about the llvm-commits mailing list