[PATCH] D57812: [ARM] Add OptMinSize Subtarget feature

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 12:20:18 PST 2019


efriedma accepted this revision.
efriedma added a subscriber: rovka.
efriedma added a comment.

LGTM



================
Comment at: lib/Target/ARM/ARMInstrInfo.td:726
   // Ideally this would be an IntImmLeaf, but then we wouldn't have access to
   // the MachineFunction.
   let GISelPredicateCode = [{
----------------
It should be possible to address this comment from https://reviews.llvm.org/rL351056, since this doesn't require a MachineFunction anymore, but I guess that can be a followup.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57812/new/

https://reviews.llvm.org/D57812





More information about the llvm-commits mailing list