[PATCH] D57639: [CodeGen] Handle vector UADDO, SADDO, USUBO, SSUBO

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 10:51:06 PST 2019


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/vec_saddo.ll:1748
+
+define <2 x i32> @saddo_v2i128(<2 x i128> %a0, <2 x i128> %a1, <2 x i128>* %p2) {
+; SSE2-LABEL: saddo_v2i128:
----------------
Please can you use nounwind on tests to avoid cfi getting in the way (I tend to add it to all basic codegen tests like these but its up to you):
e.g.
```
define <2 x i32> @saddo_v2i128(<2 x i128> %a0, <2 x i128> %a1, <2 x i128>* %p2) nounwind {
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57639/new/

https://reviews.llvm.org/D57639





More information about the llvm-commits mailing list