[PATCH] D57909: [WebAssembly] Handle mismatched signatures more gracefully

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 10:15:54 PST 2019


sbc100 created this revision.
Herald added subscribers: llvm-commits, dexonsmith, steven_wu, sunfish, aheejin, jgravelle-google, mehdi_amini, dschuff.
Herald added a project: LLVM.

Previously we could emit a warning and generate a potentially invalid
wasm module (due to call sites and functions having conflicting
signatures).  Now, rather than create invalid binaries we handle such
cases by creating stub functions containing unreachable, effectively
turning these into runtime errors rather than validation failures.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D57909

Files:
  test/wasm/archive-weak-undefined.ll
  test/wasm/cxx-mangling.ll
  test/wasm/lto/signature-mismatch.ll
  test/wasm/lto/weak-undefined.ll
  test/wasm/signature-mismatch-weak.ll
  test/wasm/signature-mismatch.ll
  test/wasm/undefined-weak-call.ll
  wasm/Config.h
  wasm/Driver.cpp
  wasm/Options.td
  wasm/SymbolTable.cpp
  wasm/SymbolTable.h
  wasm/Symbols.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57909.185810.patch
Type: text/x-patch
Size: 20785 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190207/5c2a3cca/attachment.bin>


More information about the llvm-commits mailing list