[PATCH] D56587: Fix sign/zero extension in Dwarf expressions.

[Markus Lavin via Phabricator via llvm-commits]

markus updated this revision to Diff 185753.
markus added a comment.

Updated to `DW_OP_LLVM_convert` as suggested, did the pretty printing and updated a bunch of `llvm-lit` tests to cope with the newly generated labels. Now the IR format looks like this:

  !DIExpression(DW_OP_LLVM_convert, 16, DW_ATE_signed, DW_OP_LLVM_convert, 32, DW_ATE_signed, DW_OP_stack_value)

There are some open issues that I would like feedback on. I will add inline comments at those locations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56587/new/

https://reviews.llvm.org/D56587

Files:
  docs/LangRef.rst
  include/llvm/BinaryFormat/Dwarf.h
  include/llvm/CodeGen/DIE.h
  lib/AsmParser/LLParser.cpp
  lib/BinaryFormat/Dwarf.cpp
  lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
  lib/CodeGen/AsmPrinter/DIEHash.cpp
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.h
  lib/IR/AsmWriter.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/Target/BPF/MCTargetDesc/BPFAsmBackend.cpp
  lib/Transforms/Utils/Local.cpp
  test/CodeGen/X86/2010-05-25-DotDebugLoc.ll
  test/CodeGen/X86/2010-05-26-DotDebugLoc.ll
  test/CodeGen/X86/debug-loclists.ll
  test/DebugInfo/X86/dbg-value-range.ll
  test/DebugInfo/X86/dbg-value-regmask-clobber.ll
  test/DebugInfo/X86/dw_op_minus.mir
  test/DebugInfo/X86/dwarf-pubnames-split.ll
  test/Transforms/InstCombine/cast-set-preserve-signed-dbg-val.ll
  unittests/Transforms/Utils/LocalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56587.185753.patch
Type: text/x-patch
Size: 30740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190207/3b15fb54/attachment.bin>