[PATCH] D57823: [ARM] Make fullfp16 instructions not conditionalisable.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham added a comment.

Good question. Testing it with llvm-mc, what seems to happen (with this patch applied) is that if I write one of these instructions after an explicit `it` instruction then I get "error: instructions in IT block must be predicable", but if there's no preceding IT then it's accepted without complaint.

That probably isn't what I wanted – but it's hard to revert by adding a check in `validateInstruction`, because a side effect of this change is that now `MCID.findFirstPredOperandIdx()` returns -1 for those instructions, so I can't find the operand that's already had an unacceptable condition put into it. Hmmm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57823/new/

https://reviews.llvm.org/D57823