[PATCH] D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 23:03:53 PST 2019


uabelho added a comment.

In D57149#1387325 <https://reviews.llvm.org/D57149#1387325>, @mattd wrote:

> Hi @uabelho
>
> The test case in your patch definitely causes a problem, but that's because the -start-before/-stop-after is used.  If I run that same test through llc, the UnreachableBlockElim pass kicks-in and drops the dead code.
>  I took a look at the code in your Janurary 24th comment.  I was unable to get the same dead block to surface, but most likely I had the wrong flag set.  How did you build the sample in that comment?


It can be reproduced with the full llc -O1 pipe on current trunk using:
 llc -O1 -o - pr40436.ll
F8236901: pr40436.ll <https://reviews.llvm.org/F8236901>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57149/new/

https://reviews.llvm.org/D57149





More information about the llvm-commits mailing list