[PATCH] D57215: [CodeExtractor] Clear function's assumption cache after extracting blocks from it

Wed Feb 6 15:45:41 PST 2019

sdmitriev marked an inline comment as done.
sdmitriev added inline comments.

================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:184
   struct OutlineRegionInfo {
-    OutlineRegionInfo(SmallVector<BasicBlock *, 8> Region,
+    OutlineRegionInfo(const SmallVector<BasicBlock *, 8> &Region,
                       BasicBlock *EntryBlock, BasicBlock *ExitBlock,
----------------
vsk wrote:
> nit, as this seems unrelated to the main change, perhaps it could be a followup?
Right, this is not related to the main change. I just noticed that Region is passed by value which is not very efficient. I will remove this change from this patch.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57215/new/

https://reviews.llvm.org/D57215