[PATCH] D57215: [CodeExtractor] Clear function's assumption cache after extracting blocks from it

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 14:04:20 PST 2019


vsk added a comment.

@sdmitriev thanks for the patch!



================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:202
     AU.addRequired<TargetTransformInfoWrapperPass>();
+    AU.addUsedIfAvailable<AssumptionCacheTracker>();
   }
----------------
The splitting pass does not explicitly preserve AssumptionCacheTracker. Why does this not invalidate AssumptionCacheTracker correctly? As the splitting pass does not "really" need AssumptionCacheTracker, it seems preferable to just not require it here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57215/new/

https://reviews.llvm.org/D57215





More information about the llvm-commits mailing list