[PATCH] D57803: [X86][GlobalISEL] Support lowering aligned unordered atomics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 11:21:08 PST 2019


arsenm added inline comments.


================
Comment at: test/CodeGen/X86/atomic-unordered.ll:2-6
 ; RUN: llc -O0 < %s -mtriple=x86_64-linux-generic -verify-machineinstrs -mattr=sse2 | FileCheck --check-prefix=CHECK-O0 %s
+; RUN: llc -O0 -global-isel < %s -mtriple=x86_64-linux-generic -verify-machineinstrs -mattr=sse2 | FileCheck --check-prefix=CHECK-O0-GISEL %s
 ; RUN: llc -O3 < %s -mtriple=x86_64-linux-generic -verify-machineinstrs -mattr=sse2 | FileCheck --check-prefix=CHECK-O3 %s
+; RUN: llc -O3 -global-isel < %s -mtriple=x86_64-linux-generic -verify-machineinstrs -mattr=sse2 | FileCheck --check-prefix=CHECK-O3-GISEL %s
 
----------------
I don't know about mixing GlobalISel and SelectionDAG tests.

I would also expect this to be a MIR pass which just runs the selector, but it looks like x86 is using a number of end-to-end tests for this already


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57803/new/

https://reviews.llvm.org/D57803





More information about the llvm-commits mailing list