[PATCH] D57541: [DAGCombiner] Eliminate dead stores to stack.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 09:19:06 PST 2019


courbet marked an inline comment as done.
courbet added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15386
+
+  // We walk up the chains to find stores.
+  SmallVector<SDValue, 8> Chains = {N->getOperand(0)};
----------------
niravd wrote:
> I think we should merge this with FindBetterChains. At the least we should have load/store aliasing be able to bypass unrelated lifetime nodes and vice versa.
I'm not exactly sure how to merge it, but teaching it to bypass unrelated lifetime nodes sounds like a good idea. Done.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57541/new/

https://reviews.llvm.org/D57541





More information about the llvm-commits mailing list