[PATCH] D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 09:10:56 PST 2019


fhahn added a comment.

In D57123#1382553 <https://reviews.llvm.org/D57123#1382553>, @davide wrote:

> I need to read the paper again because I forgot how the algorithm works. Please ping me in a week if I forget to review this.


Thanks Davide! On CTMark, the impact is neutral (some tiny improvements/regressions, in the noise). In some cases, computing the merge sets is more expensive, than the IDF (e.g. if we just need to place PHI nodes for a one or two allocas in a function), so we might want to pick one strategy depending on the input function.

(I also plan to refactor the implementation of both variants a bit)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57123/new/

https://reviews.llvm.org/D57123





More information about the llvm-commits mailing list