[PATCH] D57375: X86AsmParser AVX-512: Return error instead of hitting assert

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 09:06:39 PST 2019


RKSimon added a comment.

In D57375#1387060 <https://reviews.llvm.org/D57375#1387060>, @BrandonTJones wrote:

> In D57375#1387059 <https://reviews.llvm.org/D57375#1387059>, @RKSimon wrote:
>
> > test case?
>
>
> I could not find the file that includes the test case for other similar errors (such as the closing curly brace). It seems to not exist. 
>  Should I create a new test file for this?


Yes please, if you can set it up handling this case then we can add more complete test coverage in the future.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57375/new/

https://reviews.llvm.org/D57375





More information about the llvm-commits mailing list