[PATCH] D57812: [ARM] Add OptMinSize Subtarget feature

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 09:04:07 PST 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.h:570
 
-    bool shouldExpandShift(SelectionDAG &DAG, SDNode *N) const override {
-      if (DAG.getMachineFunction().getFunction().optForMinSize())
-        return false;
-      return true;
-    }
+    bool shouldExpandShift(SelectionDAG &DAG, SDNode *N) const override;
 
----------------
samparker wrote:
> fhahn wrote:
> > As the implementation is a one-liner, I guess we could keep it inline here.
> This causes a bunch of confusing declaration issues...
There's some nasty dependencies between ARMTargetLowering and ARMSubtarget, so I can't do this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57812/new/

https://reviews.llvm.org/D57812





More information about the llvm-commits mailing list