[PATCH] D57517: [llvm-objcopy] Allow using regex in name comparison

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 01:50:02 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nit fix.



================
Comment at: tools/llvm-objcopy/CopyConfig.h:54
+  StringRef Name;
+  // Regex is shared between mumltiple CopyConfig instances.
+  std::shared_ptr<Regex> R;
----------------
Nit: mumltiple -> multiple


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57517/new/

https://reviews.llvm.org/D57517





More information about the llvm-commits mailing list