[PATCH] D56075: [GuardWidening] Support widening of explicitly expressed guards

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 01:34:17 PST 2019


mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: test/Transforms/GuardWidening/basic_explicit_guards.ll:5
+
+declare void @llvm.experimental.guard(i1, ...)
+
----------------
reames wrote:
> This declaration is unused.  Can you fix that by adding at least two tests mixing guards and widenable conditions?  (i.e. one each widening from the other)
These tests have already be derived from `test/Transforms/GuardWidening/basic.ll` Does it make sense to duplicate?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56075/new/

https://reviews.llvm.org/D56075





More information about the llvm-commits mailing list