[PATCH] D57805: [HotColdSplit] Move splitting after instrumented PGO use

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 20:26:32 PST 2019


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM.



================
Comment at: test/Other/pass-pipelines.ll:13
+; RUN:     -O2 %s 2>&1 \
+; RUN:     | FileCheck %s --check-prefix=CHECK-O2 --check-prefix=USE
+; RUN: opt -disable-output -disable-verify -debug-pass=Structure \
----------------
nit, as this isn't a pgo-specific test, it might aid readability to use 'PGOUSE' (or similar) as the check prefix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57805/new/

https://reviews.llvm.org/D57805





More information about the llvm-commits mailing list