[PATCH] D57625: [TargetLibraryInfo] Update run time support for Windows

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 17:28:11 PST 2019


rnk added inline comments.


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:168
+      unsigned Minor, Micro;
+      T.getEnvironmentVersion(Version, Minor, Micro);
+    }
----------------
I think it's common for non-clang users to not have any version info in the triple. I think in these cases, we are better off setting isPartialC99 to true. For example, most of the llc tests will use version-less triples. I was mainly interested in leaving a way for users to access the old behavior by setting an old MSVC version in the triple. Sorry for the extra work, I tried to spell it out in the comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57625/new/

https://reviews.llvm.org/D57625





More information about the llvm-commits mailing list