[PATCH] D57725: [WebAssembly] Implement --trace (-y) and --trace-symbol

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Overall looks good.



================
Comment at: test/ELF/trace.s:9
 ## Check --trace alias
-# RUN: ld.lld -shared %t.foo.o -o %t.so -t 2>&1 | FileCheck %s
+# RUN: ld.lld -shared %t.foo.o -o %t.so --trace 2>&1 | FileCheck %s
----------------
unrelated change?


================
Comment at: wasm/SymbolTable.cpp:91
+    SymIndex = SymVector.size();
+    Trace = 1;
+    IsNew = true;
----------------
Use true instead of 1.


================
Comment at: wasm/SymbolTable.h:84-86
+  // Maps symbol names to index into the SymVector.  -1 means that symbols
+  // is to not yet in the vector but it should have tracing enabled if it is
+  // ever added.
----------------
Thank you for adding this comment.


================
Comment at: wasm/SymbolTable.h:92-95
+  StringRef TraceSymbol;
+
+  llvm::StringSet<> TraceSymbols;
+
----------------
Dead members.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57725/new/

https://reviews.llvm.org/D57725