[PATCH] D57749: [LLD][ELF] - Set DF_STATIC_TLS flag for i386 target.

[Ed Maste via Phabricator via llvm-commits]

emaste added a comment.

In D57749#1385666 <https://reviews.llvm.org/D57749#1385666>, @joerg wrote:

> The description is certainly not right. IE can be used from dlopen'd objects without problems as long as there is still reserved space around and the data is not initialized non-trivially or the dynamic linker is willing to fix up all threads. The point of the flag is to allow the dynamic linker to make a quick decision without having to scan the relocation table first. A classic user of this was libGL. It also applies to many platforms, not just i386. As such, please update the description before any commit.


Indeed, it appears this was originally used to have the dlopen fail, but really it's just an indicator of the object's TLS use. Search for `obj->static_tls` in the FreeBSD review to see the proposed use.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57749/new/

https://reviews.llvm.org/D57749