[PATCH] D57769: [PDB] Remove dots and canonicalize slashes when using /PDBSOURCEPATH

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Do you understand why D53149 <https://reviews.llvm.org/D53149> changed behavior on a Windows host?

I thought we had 2 issues:

1. Your patch wasn't supposed to change behavior on Windows hosts, yet it did. Understand why and fix. This shouldn't need a change like this.

2. In cross builds, it'd be nice if there was a way to get the Windows behavior, e.g. by looking for ':' (what this patch does).

Oh, I see http://reviews.llvm.org/rL344377 is different from https://reviews.llvm.org/D53149 . New in the non-reviewed bit is:

  // Only apply native and dot removal to the relative file path.  We want to
  // leave the path the user specified untouched since we assume they specified
  // it for a reason.

Is that necessary for anything? That doesn't look like the behavior we want -- we do want /pdbsourcepath:c:\foo\bar and a file with a relative path of ..\..\blah to become c:\blah. Can we undo that bit to fix (1)?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57769/new/

https://reviews.llvm.org/D57769