[PATCH] D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 11:41:21 PST 2019


paquette marked an inline comment as done.
paquette added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/IRTranslator.h:166-168
+  /// Static map of opcodes which can be translated using
+  /// translateSimpleUnaryIntrinsic.
+  const DenseMap<unsigned, unsigned> SimpleUnaryIntrinsicOpcodes = {
----------------
arsenm wrote:
> Why a map instead of a simple switch function?
Purely personal preference; I don't feel strongly either way so I'm happy to change it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57774/new/

https://reviews.llvm.org/D57774





More information about the llvm-commits mailing list