[PATCH] D57738: [llvm-objcopy] Add --redefine-syms

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/redefine-symbol.test:7
+# RUN: echo "  foo   oof #rename foo  " > %t.rename.txt
+# RUN: echo "empty" >> %t.rename.txt
+# RUN: llvm-objcopy --redefine-syms %t.rename.txt %t %t3
----------------
rupprecht wrote:
> Shouldn't this be an error?
I don't know. GNU objdump treats this a error. However this line above
```
llvm-objcopy --redefine-sym foo=oof --redefine-sym empty= %t %t2
```
says that empty symbol names are allowed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57738/new/

https://reviews.llvm.org/D57738