[PATCH] D57478: GlobalISel: Implement fewerElementsVector for shifts

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 09:51:16 PST 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1850
+                      LeftoverRegs))
+      llvm_unreachable("should have been able to extractParts");
+
----------------
arsenm wrote:
> aemerson wrote:
> > We can return 0 here to fall back instead of dying.
> Is it OK I fa failed legalization created dead instructions?
This should also consistently fail along with getNarrowTypeBreakDown, previously checked


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57478/new/

https://reviews.llvm.org/D57478





More information about the llvm-commits mailing list