[PATCH] D57760: Fix defines.txt test failure on Windows targets

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 09:16:15 PST 2019


thopre created this revision.
thopre added reviewers: jdenny, probinson, jhenderson.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

FileCheck error messages embedding the name of the FileCheck tool vary
in the casing of that name. On Unix it displays 'FileCheck' but on some
Windows system at least it shows 'filecheck.exe' as can be seen in the
defines.txt failure logs available at [1]. This changes the testcase to
accept both casing options.

[1] http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/23393/steps/test/logs/stdio


Repository:
  rL LLVM

https://reviews.llvm.org/D57760

Files:
  llvm/test/FileCheck/defines.txt


Index: llvm/test/FileCheck/defines.txt
===================================================================
--- llvm/test/FileCheck/defines.txt
+++ llvm/test/FileCheck/defines.txt
@@ -24,7 +24,7 @@
 
 ; ERRCLIEQ1: Missing equal sign in command-line definition '-DVALUE10'
 
-; ERRCLIEQ2: FileCheck{{[^:]*}}: for the -D option: requires a value!
+; ERRCLIEQ2: [fF]ile[cC]heck{{[^:]*}}: for the -D option: requires a value!
 
 ; ERRCLIVAR1: Missing pattern variable name in command-line definition '-D=10'
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57760.185327.patch
Type: text/x-patch
Size: 505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190205/35c3f0b0/attachment.bin>


More information about the llvm-commits mailing list