[PATCH] D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements

Mirko Bonadei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 07:11:57 PST 2019


mbonadei marked an inline comment as done.
mbonadei added inline comments.


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn:19
+
+    # TODO(mbonadei): FIXME.
+    # ClangSACheckers
----------------
thakis wrote:
> mbonadei wrote:
> > thakis wrote:
> > > yvesg wrote:
> > > > What should be fixed? I.e. what is the current limitation?
> > > > Static Analyzer checks not available? If so, the following deps could be commented.
> > > +1.
> > I commented out the two deps below. I will look into it in the next few days (ClangSACheckers uses tablegen and I need to read about it and learn what it does). Is it OK to land this without SACheckers support?
> Sure, that's fine.  (`git grep tablegen llvm/utils/gn` will show you lots of tablegen examples if you want to tackle these later.)
Sure, I will do it! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57329/new/

https://reviews.llvm.org/D57329





More information about the llvm-commits mailing list