[PATCH] D57748: AMDGPU: Add inverse ballot intrinsic

[Connor Abbott via Phabricator via llvm-commits]

cwabbott marked an inline comment as done.
cwabbott added inline comments.


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.inverse.ballot.ll:26
+}
+
+declare i1 @llvm.amdgcn.inverse.ballot(i64)
----------------
arsenm wrote:
> Need to add a few more tests with more complex situations (particularly one with a uniform phi, and one with a divergent phi)
Why would having a phi node change anything? As far as I can see these tests cover the only two cases that really matter for lowering this (input in SGPR and input in VGPR).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57748/new/

https://reviews.llvm.org/D57748