[PATCH] D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect.

Ivan Kulagin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 23:14:39 PST 2019


ikulagin added a comment.

@RKSimon I forgot to clarify, the PPC tests crashed on ppc64-P9-vabsd.ll: `lsub_absv_16_ext`  and pre-inc-disable.ll: `test_pre_inc_disable_1`, because now the PPC uses custom lowering the `ISD::ABS` node for vector types,

  for (MVT VT : MVT::vector_valuetypes()) {
    // add/sub are legal for all supported vector VT's.
    setOperationAction(ISD::ADD, VT, Legal);
    setOperationAction(ISD::SUB, VT, Legal);
    setOperationAction(ISD::ABS, VT, Custom);

but the custom lowering for this architecture is not specified.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49837/new/

https://reviews.llvm.org/D49837





More information about the llvm-commits mailing list