[PATCH] D57713: [WebAssembly] Make disassembler always emit most canonical name.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked 3 inline comments as done.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrCall.td:96
 
-  defm CALL_VOID : I<(outs), (ins function32_op:$callee, variable_ops),
-                     (outs), (ins function32_op:$callee),
-                     [(WebAssemblycall0 (i32 imm:$callee))],
-                     "call    \t$callee", "call\t$callee", 0x10>;
+  let IsCanonical = 1 in {
+    defm CALL_VOID : I<(outs), (ins function32_op:$callee, variable_ops),
----------------
aheejin wrote:
> I don't think we indent within a `let` block in .td files. But I also see we do in some parts in this `WebAssemblyInstrCall.td`.. How about making a separate CL that disables all indentation within `let` blocks and making that this CL dependent on that CL? For other .td files as well.
There appears to be a mix of these, but not indenting is more common. So for now I'll just not indent my new code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57713/new/

https://reviews.llvm.org/D57713