[PATCH] D57243: GlobalISel: Allow bitcount ops to have different result type

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 13:46:46 PST 2019


arsenm marked 2 inline comments as done.
arsenm added a comment.

These are all bugs hidden by not calling the observer when doing the index 0 legalization



================
Comment at: unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:338
   CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC [[Ctpop]]
   )";
 
----------------
rtereshin wrote:
> Another example of the behavior - isn't widening for type index 1 supposed to widen only the source? But as could be seen here, it ends up widening both the source and the destination. The resulting code isn't broken largely because the source and destination types of the input instruction are the same.
Yes, for these the source and dest can be separately legalized


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57243/new/

https://reviews.llvm.org/D57243





More information about the llvm-commits mailing list