[PATCH] D57705: [SamplePGO] More pipeline changes when flattened profile used in ThinLTO postlink

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 11:51:10 PST 2019


tejohnson created this revision.
tejohnson added a reviewer: wmi.
Herald added subscribers: dexonsmith, steven_wu, eraman, inglorion, mehdi_amini.
Herald added a project: LLVM.

Follow on to D54819 <https://reviews.llvm.org/D54819>/r351476.

We also don't need to perform extra InstCombine pass when we aren't
loading the sample profile in the ThinLTO backend because we have a
flattened sample profile.

Additionally, for consistency and clarity, when we aren't reloading the
sample profile, perform ICP in the same location as non-sample PGO
backends. To this end I have moved the ICP invocation for non-SamplePGO
ThinLTO down into buildModuleSimplificationPipeline (partly addresses
the FIXME where we were previously setting this up).


Repository:
  rL LLVM

https://reviews.llvm.org/D57705

Files:
  lib/Passes/PassBuilder.cpp
  test/Other/new-pm-thinlto-defaults.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57705.185115.patch
Type: text/x-patch
Size: 5964 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190204/3ec80187/attachment.bin>


More information about the llvm-commits mailing list