[PATCH] D56079: Fix invalid test in Guard Widening

Mon Feb 4 11:35:34 PST 2019

reames added a comment.

Max and I ended up discussing this offline.  Our conclusion:

1. There's a cornercase around PDT and infinite loops which needs tested.
2. The existing test is named as if it was intended to cover that case, but instead covers a separate interesting case.
3. Max is going to rename this test, and add another one to cover the PDT cornercase.

Max, provided your change only adds the new test case, you can consider that LGTM.  If there are any changes to existing test cases (beyond the function rename) or code, please post for review.  Please make sure to include a comment in the new test about the infinite loop cornercase and why it arises.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56079/new/

https://reviews.llvm.org/D56079