[PATCH] D57027: [AMDGPU] Factored PAL metadata handling out into its own class

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 09:51:07 PST 2019


tpr added a comment.

In D57027#1381468 <https://reviews.llvm.org/D57027#1381468>, @scott.linder wrote:

> The code looks good to me, but I'm wondering why the move from doing this in `AsmPrinter::EmitEndOfAsmFile` to `TargetStreamer::finish`? It seems like it is fine to emit directives in either, but I don't understand why the change here.


The idea was so that a disassembler disassembling into a TargetStreamer would go through the same code to emit the directives.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57027/new/

https://reviews.llvm.org/D57027





More information about the llvm-commits mailing list