[PATCH] D57651: GlobalISel: Fix CSE handling of buildConstant

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar accepted this revision.
aditya_nandakumar added a comment.
This revision is now accepted and ready to land.

LGTM. Please move the EXPECT_EQ changes to the other commit.



================
Comment at: include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:738
 
+  /// Build and insert \p Res = G_BUILD_VECTOR with \p Src0 replicated to fill
+  /// the number of elements
----------------
Should be Src and not Src0 here.


================
Comment at: unittests/CodeGen/GlobalISel/CSETest.cpp:33
       CSEB.buildInstr(TargetOpcode::G_ADD, {AddReg}, {MIBInput, MIBInput});
-  ASSERT_EQ(MIBAddCopy->getOpcode(), TargetOpcode::COPY);
+  EXPECT_EQ(MIBAddCopy->getOpcode(), TargetOpcode::COPY);
   auto MIBAdd2 =
----------------
Please make the EXPECT_EQ changes along with https://reviews.llvm.org/D57652


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57651/new/

https://reviews.llvm.org/D57651