[PATCH] D57658: [llvm-exegesis] Cut run time of analysis mode by another -35% (*sic*) (YamlContext::getRegNo())

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 00:31:32 PST 2019


courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/BenchmarkResult.cpp:46
 
+  llvm::StringMap<unsigned> generateRegNameToRegNoMapping() {
+    const llvm::MCRegisterInfo &RegInfo = State->getRegInfo();
----------------
please make this `const`, or  `static` + pass `RegInfo` as a parameter (slight preference for the latter).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57658/new/

https://reviews.llvm.org/D57658





More information about the llvm-commits mailing list