[PATCH] D57647: [llvm-exegesis] Throughput support in analysis mode

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

In D57647#1382720 <https://reviews.llvm.org/D57647#1382720>, @courbet wrote:

> Thanks for working on this Roman !
>
> > Yay?
>
> Indeed :)


Thank you for the review :)

> I've had a look a the analysis file, there a bunch of other interesting ones, e.g. `BT`, `BTC`, `CRC32`, `DPPD`
> 
> We seem to be doing a bad job on X87, but that does not surprise me too much :(





================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:515
+          MCSchedModel::getReciprocalThroughput(STI, *RSC.SCDesc);
+      ClusterCenterPoint[I].PerInstructionValue = Representative[I].min();
+    }
----------------
@courbet one point of note here. Is `min()` the correct pick?
It does not seem to matter though, and is what is done in https://reviews.llvm.org/D57000#change-FpxQcgWblhyw
```
  case InstructionBenchmark::InverseThroughput:
    Result = {BenchmarkMeasure::Create("inverse_throughput", MinValue)};
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57647/new/

https://reviews.llvm.org/D57647